|
Title: Distortion Post by: sciurius on July 17, 2019, 07:10:31 AM MIDI voice 30 is DistortonGuitar. I think the right name is DistortionGuitar ;) .
Title: Re: Distortion Post by: bvdp on July 17, 2019, 10:00:14 PM You are 100% correct. I'm not about to change it at this time though, just too many files around with the wrong spelling. Can we agree that it's a MMA quirk :)
If it really bothers you, add the following line to your initialization file: Patch Rename DistortonGuitar=DistortionGuitar You could also do the same thing with "Patch Set 30=DistortonGuitar" but that will generate a warning. If anyone has a suggestion for a "better" solution ... do let me know!!! BTW, this bug has been in MMA for about 10 or 15 years :) I, for one, never type in the names ... I just copy/paste from the HTML docs. Yup, I'm a crappy typist. Title: Re: Distortion Post by: sciurius on July 18, 2019, 07:32:30 AM I think it could be as easy as:
In miditables.py, change the name to 'DistortionGuitar' (as it should be). Add a fix after initializing voiceInx: voiceInx['DISTORTONGUITAR'] = voiceInx['DISTORTIONGUITAR']; Now MMA will recognize DistortonGuitar as an alias for DistortionGuitar, but never show the wrong spelling in Patch List. Patch attached. Title: Re: Distortion Post by: folderol on July 19, 2019, 08:13:57 AM Will this still work if someone enters the wrong spelling?
People get used to things - even wrong things! Title: Re: Distortion Post by: sciurius on July 19, 2019, 08:42:09 AM Yes, the patch I added in the previous message allows both spellings to be used.
Title: Re: Distortion Post by: bvdp on July 19, 2019, 04:26:41 PM Great. I will look at this and implement.
Title: Re: Distortion Post by: bvdp on July 20, 2019, 12:28:44 AM This patch has been committed. Will show in the next devel release.
It took a bit of work to figure out the documentation generator for this, but "DistortonGuitar" is gone. I've left it in the library files as an interesting historical artifact :) |