Kara-Moon Forum

Developers & Technology => Musical MIDI Accompaniment (MMA) => Topic started by: sciurius on May 22, 2020, 08:49:18 AM



Title: Small fixes
Post by: sciurius on May 22, 2020, 08:49:18 AM
Let's use this thread for small fixes not worth their own threads.

This patch fixes the error message "EndMset/MSetEnd without If".


Title: Re: Small fixes
Post by: bvdp on May 22, 2020, 04:09:26 PM
Committed. The dangers of cut/paste when writing code (I think) :)


Title: Re: Small fixes
Post by: sciurius on May 26, 2020, 06:46:43 AM
For the(a) next release, do you consider to include the zoom patterns (http://www.kara-moon.com/forum/index.php?topic=80.msg49893#msg49893) in the lib?


Title: Re: Small fixes
Post by: bvdp on May 26, 2020, 05:23:26 PM
Hmmm, did my earlier reply disappear? Could you add a little "readme" stating the author, where you got them, and (probably) how you did the conversions?

Thanks. They are now included.


Title: Re: Small fixes
Post by: bvdp on June 12, 2020, 11:48:50 PM
In line 1213 of pat.py Python 3.8.2 issues a warning. I've changed the line:

       if self.vtype is 'PLECTRUM':

to
      if self.vtype == 'PLECTRUM':

I don't think the warning is a big deal, but we might as well catch it while we can. Just another little 2 to 3 thing :)


Title: Re: Small fixes
Post by: sciurius on September 02, 2020, 06:37:23 AM
In the docs, Emulating plucked instruments: Plectrum Tracks, section Patterns, at the end:

Code:
 However, do note that you must specify either one or all the strings if you are not using a range. Again, you cannot do:

    “1. 0 80 90” ‘‘Wrong!!

This is confusing, since the example preceding it reads "1.0 0 90" and one could easiliy interpret this as “1.0 80 90” (which, in fact, is valid).
So it would better be written as

    “1.0 0 80 90”


Title: Re: Small fixes
Post by: bvdp on September 02, 2020, 04:21:29 PM
Done. I'm used 1.0 as suggested ... but I'm not sure why I didn't just use a plain old "1" for all the examples :)


Title: Re: Small fixes
Post by: sciurius on November 12, 2020, 09:31:17 PM
mma -h reports

Code:
 -II   skip premissions test for plugins (Dangerous!)

I think the right word is permissions test.


Title: Re: Small fixes
Post by: bvdp on November 12, 2020, 11:49:57 PM
Okay, permissions it is :) And to thing, I actually have a university degree in ENGLISH. Never learned to spell though ... or is it just that "proofreading is hard". I'll go with the later!


Title: Re: Small fixes
Post by: sciurius on November 16, 2020, 07:14:00 AM
Docs for IncPath use SetLibPath in the example.


Title: Re: Small fixes
Post by: bvdp on November 16, 2020, 04:22:03 PM
Got it. Too damned many paths ... mind you in this world it's nice to have a choice  :-[