Kara-Moon Forum
December 05, 2019, 05:11:52 PM *
Welcome, Guest. Please login or register.

Login with username, password and session length
News: You can go back to the main site here: Kara-Moon site
 
   Home   Help Search Login Register  
Pages: [1]
  Print  
Author Topic: Distortion  (Read 421 times)
sciurius
Full Member
***
Posts: 179



« on: July 17, 2019, 07:10:31 AM »

MIDI voice 30 is DistortonGuitar. I think the right name is DistortionGuitar  Wink .
Logged
bvdp
Kara-Moon Master
****
Posts: 1039


WWW
« Reply #1 on: July 17, 2019, 10:00:14 PM »

You are 100% correct. I'm not about to change it at this time though, just too many files around with the wrong spelling. Can we agree that it's a MMA quirk Smiley

If it really bothers you, add the following line to your initialization file:

  Patch Rename DistortonGuitar=DistortionGuitar

You could also do the same thing with "Patch Set 30=DistortonGuitar" but that will generate a warning.

If anyone has a suggestion for a "better" solution ... do let me know!!! BTW, this bug has been in MMA for about 10 or 15 years Smiley I, for one, never type in the names ... I just copy/paste from the HTML docs. Yup, I'm a crappy typist.
Logged

My online life: http://www.mellowood.ca
sciurius
Full Member
***
Posts: 179



« Reply #2 on: July 18, 2019, 07:32:30 AM »

I think it could be as easy as:

In miditables.py, change the name to 'DistortionGuitar' (as it should be).

Add a fix after initializing voiceInx:

   voiceInx['DISTORTONGUITAR'] = voiceInx['DISTORTIONGUITAR'];

Now MMA will recognize DistortonGuitar as an alias for DistortionGuitar, but never show the wrong spelling in Patch List.

Patch attached.

* distortion.patch.txt (1.32 KB - downloaded 31 times.)
Logged
folderol
Kara-Moon Master
****
Posts: 4820

Who? Me?


WWW
« Reply #3 on: July 19, 2019, 08:13:57 AM »

Will this still work if someone enters the wrong spelling?
People get used to things - even wrong things!
Logged

If you have a poem, I have a tune, and we exchange these, we can both have a poem, a tune, and a song.
- Will
sciurius
Full Member
***
Posts: 179



« Reply #4 on: July 19, 2019, 08:42:09 AM »

Yes, the patch I added in the previous message allows both spellings to be used.
Logged
bvdp
Kara-Moon Master
****
Posts: 1039


WWW
« Reply #5 on: July 19, 2019, 04:26:41 PM »

Great. I will look at this and implement.
Logged

My online life: http://www.mellowood.ca
bvdp
Kara-Moon Master
****
Posts: 1039


WWW
« Reply #6 on: July 20, 2019, 12:28:44 AM »

This patch has been committed. Will show in the next devel release.

It took a bit of work to figure out the documentation generator for this, but "DistortonGuitar" is gone. I've left it in the library files as an interesting historical artifact Smiley
Logged

My online life: http://www.mellowood.ca
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.21 | SMF © 2015, Simple Machines Valid XHTML 1.0! Valid CSS!
Page created in 0.044 seconds with 19 queries.