Print Page - Command line options for the MIDI player

Title: Command line options for the MIDI player
Post by: sciurius on August 18, 2013, 08:08:31 PM

According to the docs, the SetMIDIPlayer command can be used to set the desired MIDI player. Also:

Code:

It is permissible to include command options as well. So, for example, on Linux you might do:
SetMIDIplayer timidity -a

This works, but this does not:

Code:

SetMIDIplayer timidity -a -U

In general, one single option works, anything else is passed to player as a single, space concatenated argument.

Fix:

Code:

*** MMA/player.py~      2012-12-29 00:07:50.000000000 +0100
--- MMA/player.py       2013-08-18 22:07:50.412426773 +0200
***************
*** 107,113 ****
   
      cmd = [pl]
      if opts:
!         cmd.append(' '.join(opts))
      cmd.append(file)
  
      t=time.time()
--- 107,113 ----
   
      cmd = [pl]
      if opts:
!         cmd.extend(opts)
      cmd.append(file)
  
      t=time.time()

Title: Re: Command line options for the MIDI player
Post by: bvdp on August 18, 2013, 08:45:19 PM

Darn! I spent hours working on this bit of code to get it work on windows and linux. You are correct, of course ... can you test your change on a windows box to see if that works there as well. Might have to wrap it otherwise depending on the platform.

Thanks for catching this!

Title: Re: Command line options for the MIDI player
Post by: sciurius on August 19, 2013, 05:48:39 AM

Quote from: bvdp on August 18, 2013, 08:45:19 PM

can you test your change on a windows box to see if that works there as well.

Sorry, I don't have Windows boxes.
I'm quite confident that on Windows the command line gets joined and split again anyway, so at most it will not do any harm.

Title: Re: Command line options for the MIDI player
Post by: bvdp on August 19, 2013, 04:23:55 PM

And, further if my memory serves, the way mma sets it up with no program name or options is just fine for windows since it accepts a default midi program from the system level (file association). So, your fix is committed ... and you get a free upgrade :)

Thanks.

Kara-Moon Forum

Developers & Technology => Musical MIDI Accompaniment (MMA) => Topic started by: sciurius on August 18, 2013, 08:08:31 PM