After (more)

[sciurius]

While trying to find out why this doesn't work:

Code:

After Count=2 Drum-KickDrum2   @rhythm Seq=|3-------3-------3-------3-------|
After Count=2 Drum-PedalHiHat  @rhythm Seq=|--------6---------------6-------|
After Count=2 Drum-RideCymbal1 @rhythm Seq=|7-------7----7--7-------7----7--|

It seems that only one After is possible for a specific location, and that subsequent Afters for the same location are silently ignored. Is that intentional?

[bvdp]

No, they should not. They are supposed to be stacked. Are you using this is * repeat?

A few lines of context would help.

[sciurius]

Okay. Yes, it is related to the * repeat stuff.

Code:

After Count=2 print 2A
After Count=2 print 2B
After Count=3 print 3A
After Count=3 print 3B
After Count=4 print 4A
After Count=4 print 4B
  1  z * 6

This prints 2A, 3A, 4A. With 6 lines z instead of the * repeat it prints 2A, 2B, 3A, 3B, 4A, 4B.

[sciurius]

BTW Are you still considering adding Before? Given the recent changes to After this shouldn't be so hard now .

[bvdp]

Okay. Yes, it is related to the * repeat stuff.

Code:

After Count=2 print 2A
After Count=2 print 2B
After Count=3 print 3A
After Count=3 print 3B
After Count=4 print 4A
After Count=4 print 4B
  1  z * 6

This prints 2A, 3A, 4A. With 6 lines z instead of the * repeat it prints 2A, 2B, 3A, 3B, 4A, 4B.

Right then. I was scratching my head at some of the code when I was doing the * stuff and wondering why it was like it was ... guess that's the answer I'll look more!

[bvdp]

Before? Ummm, not sure ... just what is the point of this?

[sciurius]

Because I cannot do this:

Code:

After Count=1 Drum-KickDrum2      @rhythm  Seq=|3--3--3--3--|
Groove A
  1    z
Groove B
  2    z

After the 1st measure the Drum-KickDrum2 sequence is altered. But the Groove B statement restores the sequences so the change gets lost.

A hypothetical Before would solve this:

Code:

Before Count=2 Drum-KickDrum2      @rhythm  Seq=|3--3--3--3--|
Groove A
  1    z
Groove B
  2    z

Now the sequence alteration takes place before the 2nd bar, and after the groove change.

[bvdp]

Okay, I will need to digest this.

[bvdp]

I think this fixes the after * problem. In after.py at line 148 out-comment the loop. Should look like this then:

Code:

  fd.close()
  afterData = [ x for x in afterData if x.bar != nn]
  MMA.parse.parseFile(name)

I think we were removing discarded events too many times

Opps ... editing since it is not quite right. I still need to delete one event since we're getting a duplicate. Well, tomorrow.

[bvdp]

Hey, that was fun. Keep looking at the recursion, etc. And all along it was just that I wasn't writing all the needed data to the scratch file. The sound you hear is my head and palm connecting

Anyway, here's the patch. Let me know.

Next, guess I'll have to look at BEFORE

[sciurius]

Are you sure this is the right patch? It seems targetted to the midi channel allocation problem, not the After behaviour...

[sciurius]

While at it, would it be possible to allow zero for the Count argument, so this

    After Count=0 Statement

becomes legal and equivalent to

    Statement

[sciurius]

Can't wait to try this... This is automatically generated out of a MIDI percussion file.

[bvdp]

Are you sure this is the right patch? It seems targetted to the midi channel allocation problem, not the After behaviour...

Did you grab/process the right file? the first few lines of the file I posted read:

124,125d123
<     stuff = []
<     elns = []
127c125,129
<     nn = gbl.barNum
---
>     barNum = gbl.barNum
>     # Gather all the AFTER events for this point
>     # in the MMA file into stuff[] for pushback

And this is for the AFTER problem. Nothing to do with channel allocation

[bvdp]

While at it, would it be possible to allow zero for the Count argument, so this

    After Count=0 Statement

becomes legal and equivalent to

    Statement

Yeah ... I suppose so ... but why? If you want to do it right away why not just do it? I'm confused